Don't explicitly include upvars in the DINode produced by build_generator_variant_struct_type_di_node#107653
Closed
khuey wants to merge 1 commit into
Closed
Don't explicitly include upvars in the DINode produced by build_generator_variant_struct_type_di_node#107653khuey wants to merge 1 commit into
khuey wants to merge 1 commit into
Conversation
…ator_variant_struct_type_di_node. The upvars already appear in each individual variant, so this code is just causing them to be listed twice.
Collaborator
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
Contributor
|
Do you have some output to show this code works for async fn, async blocks, etc? Regarding the duplication, so there's real duplication of these fields in the case of, e.g. #62958. Are you sure that it's not just that at play? Specifically, I'm worried that dropping the |
Contributor
Author
|
Yeah this isn't quite good enough yet. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upvars already appear in each individual variant, so this code is just causing them to be listed twice.